Feedback for the collated code of A0003878Y

[cmkumar87]

• Looks like you have relatively fewer lines of code than your teammates (189 lines plus 88 test code lines)
• Nesting looks deep. need refactoring? Is it doing more what it should?
  • private Command prepareAdd(String args) { ...
    
    while (matcher.find()) {
• Same comment for this method too: private Command prepareSchedule(String args) {
• The fact that the two methods looks similar is more of an indication that common code can be refactored.
• Doesn't look like test case methods are following the convention taught in the earlier tutorial.

[burnflare]

• Not all my code was tagged by last week, some files were missing. This will be fixed by tomorrow's collate submission.
• Thanks for the note, I agree, will refactor.
• ^Same as above^
• I agree
• @cmkumar87 Do you mind pointing out which convention again?

[cmkumar87]

@burnflare conventions like in this PR: https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/1163/files
I am unable to find the reference in the handbook

[burnflare]

Thank you!

Sent from my iPhone

On 2 Nov 2016, at 1:32 AM, Muthu Kumar Chandrasekaran [email protected] wrote:

@burnflare conventions like in this PR: https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/1163/files
I am unable to find the reference in the handbook

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.