Fix codacy error level problems (#196)

* Fix: Avoid reassigning parameters such as 'endDateTime' * Fix: Avoid reassigning parameters such as 'endTime' * Fix: Avoid reassigning parameters such as 'args' * Fix: Use explicit scoping instead of the default package private level * Fix: Use explicit scoping instead of the default package private level
CS2103AUG2016-W11-C2 · Nov 3, 2016 · a999708 · a999708
1 parent 46c5cd3
commit a999708
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 8 deletions.
diff --git a/src/main/java/seedu/agendum/logic/commands/AddCommand.java b/src/main/java/seedu/agendum/logic/commands/AddCommand.java
@@ -63,13 +63,14 @@ public AddCommand(String name, Optional<LocalDateTime> deadlineDate)
      */
     public AddCommand(String name, Optional<LocalDateTime> startDateTime, Optional<LocalDateTime> endDateTime)
             throws IllegalValueException {
+        Optional<LocalDateTime> balancedEndDateTime = endDateTime;
         if (startDateTime.isPresent() && endDateTime.isPresent()) {
-            endDateTime = Optional.of(DateTimeUtils.balanceStartAndEndDateTime(startDateTime.get(), endDateTime.get()));
+            balancedEndDateTime = Optional.of(DateTimeUtils.balanceStartAndEndDateTime(startDateTime.get(), endDateTime.get()));
         }
         this.toAdd = new Task(
                 new Name(name),
                 startDateTime,
-                endDateTime
+                balancedEndDateTime
         );
     }
 

diff --git a/src/main/java/seedu/agendum/logic/commands/ScheduleCommand.java b/src/main/java/seedu/agendum/logic/commands/ScheduleCommand.java
@@ -37,12 +37,13 @@ public class ScheduleCommand extends Command {
     //@@author A0133367E
     public ScheduleCommand(int targetIndex, Optional<LocalDateTime> startTime,
             Optional<LocalDateTime> endTime) {
+        Optional<LocalDateTime> balancedEndTime = endTime;
         if (startTime.isPresent() && endTime.isPresent()) {
-            endTime = Optional.of(DateTimeUtils.balanceStartAndEndDateTime(startTime.get(), endTime.get()));
+            balancedEndTime = Optional.of(DateTimeUtils.balanceStartAndEndDateTime(startTime.get(), endTime.get()));
         }
         this.targetIndex = targetIndex;
         this.newStartDateTime = startTime;
-        this.newEndDateTime = endTime;
+        this.newEndDateTime = balancedEndTime;
     }
 
     @Override

diff --git a/src/main/java/seedu/agendum/logic/parser/Parser.java b/src/main/java/seedu/agendum/logic/parser/Parser.java
@@ -392,9 +392,9 @@ private Set<Integer> parseIndexes(String args) {
             return taskIds;
         }
 
-        args = args.replaceAll("[ ]+", ",").replaceAll(",+", ",");
+        String replacedArgs = args.replaceAll("[ ]+", ",").replaceAll(",+", ",");
 
-        String[] taskIdStrings = args.split(",");
+        String[] taskIdStrings = replacedArgs.split(",");
         for (String taskIdString : taskIdStrings) {
             if (taskIdString.matches("\\d+")) {
                 taskIds.add(Integer.parseInt(taskIdString));

diff --git a/src/main/java/seedu/agendum/ui/MainWindow.java b/src/main/java/seedu/agendum/ui/MainWindow.java
@@ -169,7 +169,7 @@ public void handle(KeyEvent evt) {
     /**
      * Loads the ui elements
      */
-    void fillInnerParts() {
+    public void fillInnerParts() {
         upcomingTasksPanel = UpcomingTasksPanel.load(primaryStage, getUpcomingTasksPlaceHolder(),
                 logic.getFilteredTaskList(), new UpcomingTasksPanel());
         completedTasksPanel = CompletedTasksPanel.load(primaryStage, getCompletedTasksPlaceHolder(),

diff --git a/src/main/java/seedu/agendum/ui/UiManager.java b/src/main/java/seedu/agendum/ui/UiManager.java
@@ -74,7 +74,7 @@ private Image getImage(String imagePath) {
         return new Image(MainApp.class.getResourceAsStream(imagePath));
     }
 
-    void showAlertDialogAndWait(Alert.AlertType type, String title, String headerText, String contentText) {
+    private void showAlertDialogAndWait(Alert.AlertType type, String title, String headerText, String contentText) {
         showAlertDialogAndWait(mainWindow.getPrimaryStage(), type, title, headerText, contentText);
     }