V0.4 Milestone #92
Merged
V0.4 Milestone #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods to not reset parameter. Add AliasCommandParser Add skeleton methods addPreprocessorSymbol and removePreprocessorSymbol in LogicManager to prepare for future alias implementation Update ParserTest to conduct unit test on AliasCommandParser
…eanup Merge V0.4-Refactor-And-Cleanup
Add setLogic() method in Command abstract class Add LogicRequiringCommand and ModelRequiringCommand abstract classes to provide a way to get access to logic and model dependencies Refactor *Command classes to inherit from ModelRequiringCommand and LogicRequiringCommand whereas before that they inherit directly from Command to gain dependencies.
…icManager Modify AliasCommand to prepare for its implementation Add preprocessing handling methods in MasterParser
Add AliasSymbolList as the collection class for storing AliasSymbol Add DuplicateSymbolKeywordException, SymbolKeywordNotFoundException class for errors when using AliasSymbolList add and remove method Add AliasSymbolChangedEvent for notifying observers that alias symbol has been added or removed Add XmlAdaptedAliasSymbol which is used for serialization and deserialization of AliasSymbol Modify SavvyTasker class to provide methods to add and remove AliasSymbol data into internal AliasSymbolList Modify ReadOnlySavyTasker to provide methods for accessing AliasSymbolList Modify Model interface and ModelManager class to provide methods to add and remove AliasSymbol data as well as raise AliasSymbolChangedEvent Modify XmlSerializableSavvyTasker to be capable of being stored/loaded to for AliasSymbol data Modify Logic interface to no longer expose AliasSymbol handling methods and undo/redo functionality - Changes should be communicated through events Modify LogicManager to subscribe to AliasSymbolChangedEvent to handle adding and removal of AliasSymbols and removed previous addPreprocessSymbol and removePreprocessSymbol methods Implement LogicManager.loadAllAliasSymbols() to add externally loaded symbols (from the storage) into the parser during construction stage Implement AliasCommand.execute() to work properly Refactor AliasCommandModel and AliasCommandParser to use consistent naming of AliasSymbol components Fix XmlAdaptedTask showing wrong comment Remove LogicRequiringModel class - now AliasSymbol changes are communicated through events rather than directly through LogicRequiringModel dependency
Implement UnaliasCommand.execute() to execute unalias command Refactor UnaliasCommandModel to use consistent naming Refactor AliasCommand to use consistent naming Modify ParserTest to also test UnaliasCommandParser Update UserGuide.md to reflect changes in alias and unalias command
…ying of ability of parsing a command Add dependency from AliasCommand to Logic Add checking in AliasCommand.execute() to prevent using command headers as aliasing keyword Update MasterParser.parse() to enable aliasing Update AliasCommandParser and UnaliasCommandParser to turn off aliasing Modify ParserTest to test using MasterParser instead of individual parser. Modify ParserTest to conduct parameterized testing.
V0.4 alias, Closes #69
…egistration fails, and to reject any parser with the same header as existing AliasSymbol keyword Rollback ParserTest and separated MasterParser test into its own test case Organised imports for all classes
… each undoable operation
Merge V0.4-Fix-SUT
…odels Merge V0.4-Remove-CommandModels
Previous commit did not go through for some weird reason
Merge V0.4-Qh-Collate
Collate update
Update collates
Merge V0.4-Modify-Remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.