Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser bug fixes and refinements #109

Merged
merged 1 commit into from
Nov 1, 2016
Merged

Conversation

e0003801
Copy link

Fix tokens that directly follows switches requiring a space to be recognized as an alias keyword
Remove option specifier for list command (cumbersome!)
Update parser test according to above change
Add docs to MasterParser.parse()
Fix TaskListParser comments

…ognized as an alias keyword

Remove option specifier for list command (cumbersome!)
Update parser test according to above change
Add docs to MasterParser.parse()
Fix TaskListParser comments
Copy link
Author

@e0003801 e0003801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test review

* @param userInput the text to be parse
* @return the command that was parsed if successful, or IncorrectCommand if there is no
* parser that can parse the text or if there is a format error with the text.
*/
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test code review

@@ -212,13 +212,13 @@ public void parse_list_noParametersSpaces() throws ParseException {

@Test
public void parse_list_valid() throws ParseException {
assertNotNull(listParser.parse("list t/ Priority Level "));
assertNotNull(listParser.parse("list Priority Level "));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test code review 2

@e0003801 e0003801 merged commit 4b8552d into V0.5rc Nov 1, 2016
@e0003801 e0003801 deleted the V0.5rc-Parser-Refinement branch November 2, 2016 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant