Import natty to support natural language #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you can merge after making it more defensive. |
shixiyue
reviewed
Oct 27, 2016
| @@ -35,6 +41,11 @@ | |||
| public AddCommand(String name, String deadline, Set<String> tags,String freq) | |||
| throws IllegalValueException { | |||
| final Set<Tag> tagSet = new HashSet<>(); | |||
| DateFormat dateFormat = new SimpleDateFormat("dd.MM.yyyy"); | |||
| if(!deadline.matches(DATE_VALIDATION_REGEX)&&!deadline.equals("")){ | |||
| List<Date> date = new com.joestelmach.natty.Parser().parse(deadline).get(0).getDates(); | |||
There was a problem hiding this comment.
What if it is an invalid date that cannot be parsed by natty? i.e. d/hi
In this case, new com.joestelmach.natty.Parser().parse(deadline) will return an empty array list which cause IndexOutOfBoundsException for get(0).
So perhaps you can check the size first?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.