Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Automatically refresh production panel #9

Merged
merged 1 commit into from
Oct 29, 2016
Merged

Automatically refresh production panel #9

merged 1 commit into from
Oct 29, 2016

Conversation

olegbl
Copy link

@olegbl olegbl commented Oct 29, 2016

Right now, when changing the production in a city, the production panel becomes out
of date (i.e. the last selected item is not available for selection).
Enabling this event handler causes the production panel to be refreshed
whenever the production changes.

Right now, when changing the production in a city, the panel becomes out
of date (i.e. the last selecteds item is not available for selection).
Enabling this event handler causes the production panel to be refreshed
whenever the production changes.
@chaorace
Copy link
Member

Yes, this is a consequence of my not 100% understanding what was going on when I started working on the cityview. I'd like to revisit making the cityview more stateful overall so it's less likely to break like this. A similar issue that's been bugging me is purchasing buildings, which causes a similar mess

@olegbl
Copy link
Author

olegbl commented Oct 29, 2016

Turns out that issue was not related to this change (filed a separate bug). This seems to work pretty well. (I'm debugging #10, doesn't look too crazy to fix by simply also closing the production panel.)

@chaorace
Copy link
Member

I can't test right now, but the change is benign enough and the issue I originally disabled this to deal with has already been resolved, so I'm just going to merge this straight in. There's a chance that enabling this will make some of the Refresh() invokations scattered around redundant, so keep an eye open for those situations.

@chaorace chaorace merged commit 336be23 into CQUI-Org:master Oct 29, 2016
@olegbl olegbl deleted the refresh-production-panel branch October 30, 2016 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants