This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Close the city view when city overview panel being closed due to selection change #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esh-production-panel
…ction change When the selection changes (i.e. buying building with gold or starting a new building in a district), the city overview panel closes in order to show some on-map animation. However, the production panel remains open and the view remains zoomed in. This commit fixes the issue (tracked by bug #10).
olegbl
commented
Oct 29, 2016
| @@ -552,6 +552,7 @@ function OnCitySelectionChanged( ownerPlayerID:number, cityID:number, i:number, | |||
| Refresh(); | |||
| else | |||
| Close(); | |||
| UI.SetInterfaceMode(InterfaceModeTypes.SELECTION); | |||
There was a problem hiding this comment.
Really this should be in Close() but I don't know all the callsites of Close() and hence don't want to introduce a different regression.
There was a problem hiding this comment.
I agree, really I want to reimplement how the prod panel behaves from vanilla again to get it right this time, but for the meantime this should fix the unexpected behavior
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the selection changes (i.e. buying building with gold or starting a new building in a district), the city overview panel closes in order to show some on-map animation. However, the production panel remains open and the view remains zoomed in. This commit fixes the issue (tracked by bug #10).