Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

New districts don't show up in the city build list if the city view is open with SHIFT #33

Closed
perseghini opened this issue Nov 3, 2016 · 3 comments
Assignees
Labels

Comments

@perseghini
Copy link

  • Astronomy research complete
  • Open a city with SHIFT key (Enhanced binding)
  • Holy Site District not in the city build list
  • Close the city view (Right Click)
  • Open the city again but through clicking on its name instead of SHIFT
  • Holy Site District is now in the city build list
  • Then reopen the city view with SHIFT key, and now the Holy Site District is here.

(I guess the refresh city build list is not refreshed with SHIFT ?)

@chaorace chaorace added the bug label Nov 3, 2016
@chaorace chaorace self-assigned this Nov 3, 2016
@chaorace
Copy link
Member

chaorace commented Nov 3, 2016

Thanks for the heads up, I'll start looking into it

@perseghini
Copy link
Author

I don't want to make a pull request for this but changing this:

if( uiKey == Keys.VK_SHIFT ) then
   if(CQUI_cityview) then
      LuaEvents.CQUI_CityviewDisable();
      UI.SelectNextReadyUnit();
   else
     LuaEvents.CQUI_CityviewEnable();
     LuaEvents.CQUI_GoNextCity();
  end
end

to that :

if( uiKey == Keys.VK_SHIFT ) then
   if(CQUI_cityview) then
      LuaEvents.CQUI_CityviewDisable();
      UI.SelectNextReadyUnit();
   else
     LuaEvents.CQUI_GoNextCity();
     LuaEvents.CQUI_CityviewEnable();
  end
end

seems to fix the issue. I didn't test it a lot, and I only had one city (so GoNextCity() stayed on the same city..)
so you might need to tweak it a bit and test it more.

Hope, it helps !

Cheers.

@chaorace
Copy link
Member

chaorace commented Nov 3, 2016

Yes, that seems to have done it, I'm committing this change now. Thanks!

chaorace added a commit that referenced this issue Nov 3, 2016
Thanks @perseghini for submitting the fix for this! ❤️
@chaorace chaorace closed this as completed Nov 3, 2016
chaorace added a commit that referenced this issue Nov 3, 2016
It happens to the best of us when we're tired, okay?
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants