Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dataflow builder methods for angle ops #596

Merged
merged 2 commits into from
Sep 6, 2024
Merged

feat: dataflow builder methods for angle ops #596

merged 2 commits into from
Sep 6, 2024

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Sep 5, 2024

No description provided.

@ss2165 ss2165 requested a review from a team as a code owner September 5, 2024 15:30
@ss2165 ss2165 requested a review from doug-q September 5, 2024 15:30
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 84.28571% with 11 lines in your changes missing coverage. Please review.

Project coverage is 83.04%. Comparing base (dd9592f) to head (1c938fe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tket2/src/extension/angle.rs 84.28% 0 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   83.03%   83.04%   +0.01%     
==========================================
  Files          45       45              
  Lines        6194     6264      +70     
  Branches     6194     6264      +70     
==========================================
+ Hits         5143     5202      +59     
  Misses        762      762              
- Partials      289      300      +11     
Flag Coverage Δ
rust 83.04% <84.28%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest a shorter idiom for these functions, but otherwise this is great!

@ss2165 ss2165 enabled auto-merge September 6, 2024 10:32
@ss2165 ss2165 added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit dcc562d Sep 6, 2024
15 checks passed
@ss2165 ss2165 deleted the ss/angle-build branch September 6, 2024 10:39
lmondada pushed a commit that referenced this pull request Oct 1, 2024
## 🤖 New release
* `tket2`: 0.2.0 -> 0.3.0
* `tket2-hseries`: 0.2.0 -> 0.3.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`
<blockquote>

##
[0.3.0](tket2-v0.2.0...tket2-v0.3.0)
- 2024-09-09

### Bug Fixes

- extension ops checking against incorrect name
([#593](#593))
- [**breaking**] remove TryFrom for extension ops use `cast`
([#592](#592))
- don't load angle extensions on to quantum
([#597](#597))

### New Features

- [**breaking**] move angle types + and ops to new "tket2.angle"
extension ([#591](#591))
- dataflow builder methods for angle ops
([#596](#596))
- lowering tk2ops -> hseriesops
([#579](#579))
</blockquote>

## `tket2-hseries`
<blockquote>

##
[0.3.0](tket2-hseries-v0.2.0...tket2-hseries-v0.3.0)
- 2024-09-09

### Bug Fixes

- extension ops checking against incorrect name
([#593](#593))
- [**breaking**] remove TryFrom for extension ops use `cast`
([#592](#592))

### New Features

- lowering tk2ops -> hseriesops
([#579](#579))
- *(tket2-hseries)* cli extension dumping
([#584](#584))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants