feat: Arbitrary types in the yaml extension definition #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still a work-in-progress definition, as we don't have a scheme for the declarative extensions in the spec. In particular, name resolution is a bit fuzzy. Right now it just matches on type names (using See #841 |
ss2165
approved these changes
Feb 21, 2024
| ext: ext.name().clone(), | ||
| ty: self.0.clone(), | ||
| })?; | ||
| let Some(op_def) = self.resolve_type(ext, ctx) else { |
There was a problem hiding this comment.
Suggested change
| let Some(op_def) = self.resolve_type(ext, ctx) else { | |
| let Some(type_def) = self.resolve_type(ext, ctx) else { |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current yaml extension definitions only support hard-coded types in the operation signatures.
This PR leaves the existing
QandUSizehardcoded values, but tries to dereference the type name from the extensions in scopes otherwise.drive-by: Extend the module doc with an example on how to load the extension.