Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide+implement Replace API #613

Merged
merged 75 commits into from
Nov 8, 2023
Merged

feat: Provide+implement Replace API #613

merged 75 commits into from
Nov 8, 2023

Commits on Oct 16, 2023

  1. Add Replacement struct, NewEdgeSpec/NewEdgeKind, verify, invalidation… 

    …_set
    @acl-cqc
    acl-cqc committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    2467729 View commit details
    Browse the repository at this point in the history

  2. WIP Implement

    @acl-cqc
    acl-cqc committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    8e531d4 View commit details
    Browse the repository at this point in the history

  3. Allow returning HugrError or Msg

    @acl-cqc
    acl-cqc committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    e9f4ba8 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Check edges

    @acl-cqc
    acl-cqc committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    886fba6 View commit details
    Browse the repository at this point in the history

  2. Allow replacing edges from any node in S*; update spec

    @acl-cqc
    acl-cqc committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    ccf5200 View commit details
    Browse the repository at this point in the history

  3. xxx_edges => mu_xxx (xxx = out, new, in -> inp)

    @acl-cqc
    acl-cqc committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    50abda1 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Make NewEdgeSpec+Replacement fields pub; run SimpleReplacement tests … 

    …via applicator
    @acl-cqc
    acl-cqc committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    366209c View commit details
    Browse the repository at this point in the history

  2. fmt

    @acl-cqc
    acl-cqc committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    2b8c86f View commit details
    Browse the repository at this point in the history

  3. fix - new_node already in h, no need to translate

    @acl-cqc
    acl-cqc committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    de14f04 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Convert ReplaceError::Msg into cases

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    a996f47 View commit details
    Browse the repository at this point in the history

  2. clippy

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    d78cbf2 View commit details
    Browse the repository at this point in the history

  3. Rewrite incoming-edge check

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    e6c3d8c View commit details
    Browse the repository at this point in the history

  4. Shorter 'descends'

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    d70444e View commit details
    Browse the repository at this point in the history

  5. Check parent in apply

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    6e94467 View commit details
    Browse the repository at this point in the history

  6. insertion shouldn't fail?? Drop HugrError

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    dcccde9 View commit details
    Browse the repository at this point in the history

  7. v1 verify checks port kind

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    7366aa7 View commit details
    Browse the repository at this point in the history

  8. BadEdgeKind stores Direction (temp remove check on adding Order edges)

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    46d2f48 View commit details
    Browse the repository at this point in the history

  9. Break out check_existing_edge; transfer_edge does checks too

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    1d15e72 View commit details
    Browse the repository at this point in the history

  10. BadEdgeSpec: str -> Direction, Node -> Edge

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    e371fc3 View commit details
    Browse the repository at this point in the history

  11. apply fails w/BadEdgeSpec for replacement nodes

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    16b52b4 View commit details
    Browse the repository at this point in the history

  12. Note what checks required

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    3701d50 View commit details
    Browse the repository at this point in the history

  13. Factor out get_removed_nodes

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    677692a View commit details
    Browse the repository at this point in the history

  14. transfer_edges: translation func returns Result<Node, WhichHugr>

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    b2a7f00 View commit details
    Browse the repository at this point in the history

  15. Use get_removed in apply

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    86d6f39 View commit details
    Browse the repository at this point in the history

  16. Add missing docs; move 'impl NewEdgeSpec' after struct def for Replac… 

    …ement
    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    4738710 View commit details
    Browse the repository at this point in the history

  17. fixup! Use get_removed

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    94f0586 View commit details
    Browse the repository at this point in the history

  18. WIP test - failing in extension inference?!

    @acl-cqc
    acl-cqc committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    c4d5996 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Directly build Hugr rather than using Builder

    @acl-cqc
    acl-cqc committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    c23b798 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Fix initial Hugr building (using Lift!)

    @acl-cqc
    acl-cqc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    476f0a3 View commit details
    Browse the repository at this point in the history

  2. Fix root type of replacement, fmt

    @acl-cqc
    acl-cqc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    52c7c54 View commit details
    Browse the repository at this point in the history

  3. Fix: translate transfer-keys using node_map

    @acl-cqc
    acl-cqc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    50b7b5c View commit details
    Browse the repository at this point in the history

  4. Check transfer keys too

    @acl-cqc
    acl-cqc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1bef633 View commit details
    Browse the repository at this point in the history

  5. WIP debug

    @acl-cqc
    acl-cqc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    72f9bf2 View commit details
    Browse the repository at this point in the history

  6. Revert "WIP debug" 

    This reverts commit 72f9bf2.
    @acl-cqc
    acl-cqc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    be28f21 View commit details
    Browse the repository at this point in the history

  7. Removal a list not a set, order matters

    @acl-cqc
    acl-cqc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3ae6d10 View commit details
    Browse the repository at this point in the history

  8. Rename variables in test

    @acl-cqc
    acl-cqc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d41300a View commit details
    Browse the repository at this point in the history

  9. Update_validate, open_extensions, fix ports+wiring for predicate

    @acl-cqc
    acl-cqc committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1c96bbd View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Merge commit 'origin/main^' into new/replace

    @acl-cqc
    acl-cqc committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    d383856 View commit details
    Browse the repository at this point in the history

  2. Update renamed predicate->tuple/unit_sum

    @acl-cqc
    acl-cqc committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    5eaf13a View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Remove lift nodes, use open_extensions for Const + load-constant

    @acl-cqc
    acl-cqc committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3fec96a View commit details
    Browse the repository at this point in the history

  2. CI fmt

    @acl-cqc
    acl-cqc committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    51164a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Merge remote-tracking branch 'origin/main' into HEAD

    @acl-cqc
    acl-cqc committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5aeedb2 View commit details
    Browse the repository at this point in the history

  2. Update re. port directions

    @acl-cqc
    acl-cqc committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    0ce6900 View commit details
    Browse the repository at this point in the history

  3. CI fmt more

    @acl-cqc
    acl-cqc committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    002e89a View commit details
    Browse the repository at this point in the history

  4. Rewrite test using builder again; no lift nodes, Const has singleton-… 

    …collections
    @acl-cqc
    acl-cqc committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    b35eb86 View commit details
    Browse the repository at this point in the history

  5. clippy

    @acl-cqc
    acl-cqc committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7a3029d View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Spec tweaks courtesy of Alec 

    Co-authored-by: Alec Edgington <[email protected]>
    @acl-cqc @cqc-alec
    acl-cqc and cqc-alec authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    b463fd3 View commit details
    Browse the repository at this point in the history

  2. Yes PartialEq, no Eq

    @acl-cqc
    acl-cqc committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    31a743d View commit details
    Browse the repository at this point in the history

  3. transfers->adoptions, fix doclinks, spec names

    @acl-cqc
    acl-cqc committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    8ace22b View commit details
    Browse the repository at this point in the history

  4. Note non-signature equality

    @acl-cqc
    acl-cqc committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    0014577 View commit details
    Browse the repository at this point in the history

  5. WrongRootNodeTag: expected->removed, actual->replacement

    @acl-cqc
    acl-cqc committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5436256 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/main' into new/replace

    @acl-cqc
    acl-cqc committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    154b298 View commit details
    Browse the repository at this point in the history

  7. no open_extensions

    @acl-cqc
    acl-cqc committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    da568ca View commit details
    Browse the repository at this point in the history

  8. TransfersNotSeparateDescendants is a general case of ConflictingTrans… 

    …fers
    @acl-cqc
    acl-cqc committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    f1c2114 View commit details
    Browse the repository at this point in the history

  9. Assert about the Hugr

    @acl-cqc
    acl-cqc committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a5cca09 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Start on test - build conditional Hugr

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    961026f View commit details
    Browse the repository at this point in the history

  2. Test duplicate 'adoptions' rhs

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b8180d7 View commit details
    Browse the repository at this point in the history

  3. Rename {case,r}_t/f to {case,r}1/2

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    e5c426d View commit details
    Browse the repository at this point in the history

  4. Test wrong root node type

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    326365f View commit details
    Browse the repository at this point in the history

  5. Functional style using ..r.clone(), test CantReplaceRoot

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    2d6a7b6 View commit details
    Browse the repository at this point in the history

  6. MultipleParents

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    8b5ed23 View commit details
    Browse the repository at this point in the history

  7. InvalidTransferTarget

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    71786a9 View commit details
    Browse the repository at this point in the history

  8. Invalid(TransferTarget=>AdoptingParent), (Transfers=>Adoptees)NotSepa… 

    …rateDescendants, doclinks
    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    65abd61 View commit details
    Browse the repository at this point in the history

  9. Comments, one BadEdgeSpec

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    804a005 View commit details
    Browse the repository at this point in the history

  10. Another BadEdgeSpec test

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    ed440b6 View commit details
    Browse the repository at this point in the history

  11. NotSeparateDescendants - comment nodes are best-effort

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    c502018 View commit details
    Browse the repository at this point in the history

  12. BadEdgeKind

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b1dbfc4 View commit details
    Browse the repository at this point in the history

  13. Run tests on both verify + apply, include one on mu_new

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    fcf8827 View commit details
    Browse the repository at this point in the history

  14. WIP test NoRemovedEdge...failing

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    eb3c519 View commit details
    Browse the repository at this point in the history

  15. Fix for both

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    17b1618 View commit details
    Browse the repository at this point in the history

  16. refactor: move descends_any inside check_existing_edge

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    8788dc7 View commit details
    Browse the repository at this point in the history

  17. Merge remote-tracking branch 'origin/main' into new/replace

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    aba2f41 View commit details
    Browse the repository at this point in the history

  18. Generalize Container::add_constant, pass None

    @acl-cqc
    acl-cqc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    1b39df7 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Merge 'origin/main' into new/replace, update add_{op=>node}_...

    @acl-cqc
    acl-cqc committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    ce9311a View commit details
    Browse the repository at this point in the history

  2. Simplify invalidation_set

    @acl-cqc
    acl-cqc committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    bbb172d View commit details
    Browse the repository at this point in the history