Rewrites work on any HugrMut #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acl-cqc
force-pushed
the
new/rewrite_hugrmut
branch
from
e575bf9
to
1bb6d11
Compare
acl-cqc
force-pushed
the
new/buildable_hugrmut
branch
2 times, most recently
from
19037c7
to
5e64b0a
Compare
acl-cqc
force-pushed
the
new/rewrite_hugrmut
branch
from
1bb6d11
to
d82c093
Compare
acl-cqc
force-pushed
the
new/rewrite_hugrmut
branch
from
c5e017c
to
91d07bb
Compare
acl-cqc
force-pushed
the
new/rewrite_hugrmut
branch
from
91d07bb
to
b6b1cbd
Compare
acl-cqc
changed the base branch from
new/buildable_hugrmut
to
refactor/outline_cfg_insert_hugr
acl-cqc
force-pushed
the
new/rewrite_hugrmut
branch
from
b6b1cbd
to
464f56b
Compare
acl-cqc
changed the title
|
@aborgna-q ping - this is a bit out-of-date but I'm wondering if I should update it or drop it? |
acl-cqc
changed the title
The merge was very straightforward: remove all changes to HugrMut itself from this PR :-) :-). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite::verify takes &impl HugrView (not &Hugr); Rewrite::apply takes &mut impl HugrMut (not &mut Hugr).
TransactionalRewrite backs up the portion inside the HugrMut and then restores - this feels a little awkward but may be ok, still not tested though.