Implement `SimpleReplace` #114

cqc-alec · 2023-06-05T07:58:36Z

This PR includes and implements #85 .

Since we don't yet have DFG-rooted HUGRs we use a workaround where the replacement graph is specified as a HUGR with a unique DFG node. Once #112 is merged we can remove this workaround.

Not to be merged since it assumes multiports, which are not yet reflected in the spec.

acl-cqc

Looks good, but the portgraph manipulating code is not as easy as I'd hoped! Would be nice if we can make that more readable at all - perhaps by super-consistent naming.

acl-cqc · 2023-06-05T10:55:37Z

src/hugr.rs

+        r: SimpleReplacement,
+    ) -> Result<(), SimpleReplacementError> {
+        // 1. Check the parent node exists.
+        if self.nodes().all(|node| node != r.p) || self.get_optype(r.p).tag() != OpTag::Dfg {


This is accessing the nodes using self as a HugrView, right? Nice as that might be, this makes the rewrite O(n) in the size of the whole Hugr, not the fragment being replaced, which seems bad. I think from here (inside impl Hugr) we can access self.graph directly (or perhaps self.hierarchy, as you do below), which could reduce this to O(1).

acl-cqc · 2023-06-05T11:08:49Z

src/hugr.rs

+            let n_node = Node { index: *n_index };
+            let op: &OpType = r.n.get_optype(n_node);


Suggested change

let n_node = Node { index: *n_index };

let op: &OpType = r.n.get_optype(n_node);

let op: &OpType = r.n.get_optype((*n_index).into());

acl-cqc · 2023-06-05T11:11:29Z

src/hugr.rs

+            let op: &OpType = r.n.get_optype(n_node);
+            let sig = op.signature();
+            if !sig.const_input.is_empty() {
+                return Err(SimpleReplacementError::InvalidReplacementNode());


This does mean the HUGR has been mutated i.e. we are midway through the replacement. So, while I admit it would probably involve recomputing op for each node, how about doing this check in advance, e.g., using n_non_io_indices.all(|n_index|....)

acl-cqc · 2023-06-05T11:14:05Z

src/hugr.rs

+        let n_non_io_indices = &n_indices[1..n_sz - 1]; // omit Input and Output
+        let self_input_node_index: NodeIndex = self.hierarchy.first(r.p.index).unwrap();
+        let n_output_node_index: NodeIndex = n_indices[n_sz - 1];
+        for n_index in n_non_io_indices {


Hmmmm, I'm not 100% sure of my Rust here, but can you do

for &n_index in n_non_io_indices {

here and then avoid the * before each n_index in the loop?

acl-cqc · 2023-06-05T11:54:35Z

src/hugr.rs

+        let n_indices =
+            r.n.hierarchy
+                .children(n_dfg_node.index)
+                .collect::<Vec<NodeIndex>>();


Hmmm, still looking at the conversion to Node done (at least twice) below, another way would be to do that here - I think .map_into (from itertools) would do it, or .into or just collect::<Vec<Node>>. That would mean you'd need to .index in a few more places but might be neater overall.

acl-cqc · 2023-06-05T12:29:26Z

src/replacement/simple_replace.rs

+
+    const QB: SimpleType = SimpleType::Linear(LinearType::Qubit);
+
+    /// Creates a hugr with a DFG.


When we have rooted-at-any-op Hugrs, we might as well skip much of this as well, right? (Just to simplify the test)

src/replacement/simple_replace.rs

acl-cqc · 2023-06-05T12:31:21Z

src/replacement/simple_replace.rs

+            let [qb0, qb1] = func_builder.input_wires_arr();
+
+            let mut inner_builder =
+                func_builder.dfg_builder(vec![(QB, qb0), (QB, qb1)], type_row![QB, QB])?;


and ASCII art again

acl-cqc · 2023-06-05T12:34:15Z

src/replacement/simple_replace.rs

+            .unwrap();
+        let (n_node_h0, n_node_h1) = n.input_neighbours(n_node_cx).collect_tuple().unwrap();
+        // 4.2. Locate the ports we need to specify as "glue" in n
+        let n_port_0 = n.node_ports(n_node_h0, Direction::Incoming).next().unwrap();


note as well as .next() there is .exactly_one() if you use itertools::Itertools

src/replacement/simple_replace.rs

aborgna-q

I strongly suggest using more meaningful names in the implementation. Having to go to an internal definition in another module to parse what r.s adds a lot of friction.

src/replacement.rs

src/replacement/simple_replace.rs

src/hugr.rs

specification/hugr.md

src/hugr.rs

cqc-alec · 2023-06-07T14:56:05Z

I think this now handles empty wires correctly. Note the updated spec.

cqc-alec · 2023-06-07T15:03:49Z

Some fixes needed following merge from latest main; update to follow...

aborgna-q

Result::ok just casts the value to an Option, discarding any error information. In most cases calling that before unwrap will give less debug info.

aborgna-q · 2023-06-08T09:41:22Z

specification/hugr.md

  - a map $\nu\_\textrm{inp}: \textrm{inp}\_H(T \setminus \\{\texttt{Input}\\}) \to \textrm{inp}\_{\Gamma}(S)$;
  - a map $\nu_\textrm{out}: \textrm{out}_{\Gamma}(S) \to \textrm{out}_H(T \setminus \\{\texttt{Output}\\})$.


I think the subindices are wrong here?

Suggested change

- a map $\nu\_\textrm{inp}: \textrm{inp}\_H(T \setminus \\{\texttt{Input}\\}) \to \textrm{inp}\_{\Gamma}(S)$;

- a map $\nu_\textrm{out}: \textrm{out}_{\Gamma}(S) \to \textrm{out}_H(T \setminus \\{\texttt{Output}\\})$.

- a map $\nu\_\textrm{inp}: \textrm{inp}\_{\Gamma}(T \setminus \\{\texttt{Input}\\}) \to \textrm{inp}\_H(S)$;

- a map $\nu_\textrm{out}: \textrm{out}_H(S) \to \textrm{out}_{\Gamma}(T \setminus \\{\texttt{Output}\\})$.

I think they are correct? T is a set in H, and S is a set in Gamma.

Just above it says:

Given a set $S$ of nodes in a hugr $H$, let:

I see the confusion. But that is a different H (scoped to the definition). I will change the definition to use a different letter!

src/replacement/simple_replace.rs

aborgna-q · 2023-06-08T09:52:56Z

src/replacement/simple_replace.rs

+            nu_inp,
+            nu_out,
+        };
+        h.apply_simple_replacement(r).ok();


Suggested change

h.apply_simple_replacement(r).ok();

h.apply_simple_replacement(r).unwrap();

aborgna-q · 2023-06-08T09:53:19Z

src/replacement/simple_replace.rs

+            nu_inp,
+            nu_out,
+        };
+        h.apply_simple_replacement(r).ok();


Suggested change

h.apply_simple_replacement(r).ok();

h.apply_simple_replacement(r).unwrap();

src/hugr.rs

aborgna-q · 2023-06-08T10:12:20Z

src/hugr.rs

Is the idea to move apply_simple_replacement to simple_replace.rs once #119 is done?
The code could be moved over there now, so it's less noisy to change that afterwards.

Yeah I was going to wait until that was done, since there isn't really a framework for it yet.

cqc-alec · 2023-06-08T10:46:52Z

Result::ok just casts the value to an Option, discarding any error information. In most cases calling that before unwrap will give less debug info.

Thanks, yes. It seems I can't change all instances of .ok().unwrap() though because of errors like:

error[E0277]: `NodePortOffsets` doesn't implement `Debug`
    --> src/replacement/simple_replace.rs:230:14
     |
230  |             .unwrap();
     |              ^^^^^^ `NodePortOffsets` cannot be formatted using `{:?}` because it doesn't implement `Debug`
     |
     = help: the trait `Debug` is not implemented for `NodePortOffsets`
     = help: the trait `Debug` is implemented for `ExactlyOneError<I>`
     = note: required for `itertools::adaptors::map::MapSpecialCase<NodePortOffsets, itertools::adaptors::map::MapSpecialCaseFnInto<Port>>` to implement `Debug`
     = note: 1 redundant requirement hidden
     = note: required for `ExactlyOneError<MapSpecialCase<NodePortOffsets, MapSpecialCaseFnInto<Port>>>` to implement `Debug`
     = note: the full type name has been written to '/home/alec/r/hugr/target/debug/deps/hugr-653fda1ba5647c44.long-type-8370086427390340701.txt'
note: required by a bound in `Result::<T, E>::unwrap`
    --> /home/alec/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/result.rs:1085:12
     |
1085 |         E: fmt::Debug,
     |            ^^^^^^^^^^ required by this bound in `Result::<T, E>::unwrap`

Will change what I can.

#139 wasn't compatible with #114

## 🤖 New release * `hugr-llvm`: 0.5.1 -> 0.6.0 (⚠️ API breaking changes) ### ⚠️ `hugr-llvm` breaking changes ``` --- failure auto_trait_impl_removed: auto trait no longer implemented --- Description: A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented. ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/auto_trait_impl_removed.ron Failed in: type TypeConverter is no longer UnwindSafe, in /tmp/.tmpGjujM0/hugr-llvm/src/types.rs:59 type TypeConverter is no longer RefUnwindSafe, in /tmp/.tmpGjujM0/hugr-llvm/src/types.rs:59 --- failure derive_trait_impl_removed: built-in derived trait no longer implemented --- Description: A public type has stopped deriving one or more traits. This can break downstream code that depends on those types implementing those traits. ref: https://doc.rust-lang.org/reference/attributes/derive.html#derive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/derive_trait_impl_removed.ron Failed in: type TypeConverter no longer derives Copy, in /tmp/.tmpGjujM0/hugr-llvm/src/types.rs:59 type TypeConverter no longer derives Clone, in /tmp/.tmpGjujM0/hugr-llvm/src/types.rs:59 type TypeConverter no longer derives Debug, in /tmp/.tmpGjujM0/hugr-llvm/src/types.rs:59 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/function_missing.ron Failed in: function hugr_llvm::custom::prelude::array::emit_array_op, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/prelude/array.rs:51 function hugr_llvm::custom::int::add_int_extensions, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/int.rs:226 function hugr_llvm::custom::rotation::add_rotation_extensions, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/rotation.rs:196 function hugr_llvm::custom::prelude::add_prelude_extensions, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/prelude.rs:295 function hugr_llvm::custom::float::add_float_extensions, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/float.rs:186 function hugr_llvm::custom::conversions::add_conversions_extension, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/conversions.rs:270 function hugr_llvm::custom::logic::add_logic_extensions, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/logic.rs:106 function hugr_llvm::custom::prelude::add_default_prelude_extensions, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/prelude.rs:304 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/inherent_method_missing.ron Failed in: TypeConverter::new, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/types.rs:107 TypeConverter::iw_context, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/types.rs:112 CodegenExtsMap::add_float_extensions, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/float.rs:192 CodegenExtsMap::add_int_extensions, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/int.rs:234 CodegenExtsMap::add_logic_extensions, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/logic.rs:113 CodegenExtsMap::add_default_prelude_extensions, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/prelude.rs:311 CodegenExtsMap::add_prelude_extensions, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/prelude.rs:317 CodegenExtsMap::add_rotation_extensions, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/rotation.rs:201 CodegenExtsMap::new, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom.rs:88 CodegenExtsMap::add_cge, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom.rs:97 CodegenExtsMap::get, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom.rs:110 CodegenExtsMap::llvm_type, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom.rs:120 CodegenExtsMap::emit, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom.rs:130 CodegenExtsMap::load_constant, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom.rs:145 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/module_missing.ron Failed in: mod hugr_llvm::custom::conversions, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/conversions.rs:1 mod hugr_llvm::custom::logic, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/logic.rs:1 mod hugr_llvm::custom::int, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/int.rs:1 mod hugr_llvm::custom::prelude, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/prelude.rs:1 mod hugr_llvm::fat, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/fat.rs:1 mod hugr_llvm::custom::float, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/float.rs:1 mod hugr_llvm::custom::rotation, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/rotation.rs:1 mod hugr_llvm::custom::prelude::array, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/prelude/array.rs:1 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/struct_missing.ron Failed in: struct hugr_llvm::custom::logic::LogicCodegenExtension, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/logic.rs:78 struct hugr_llvm::fat::FatNode, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/fat.rs:28 struct hugr_llvm::custom::int::IntOpsCodegenExtension, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/int.rs:120 struct hugr_llvm::custom::prelude::PreludeCodegenExtension, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/prelude.rs:174 struct hugr_llvm::custom::float::FloatTypesCodegenExtension, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/float.rs:27 struct hugr_llvm::emit::NullEmitLlvm, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/emit.rs:52 struct hugr_llvm::custom::conversions::ConversionsCodegenExtension, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/conversions.rs:244 struct hugr_llvm::custom::prelude::DefaultPreludeCodegen, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/prelude.rs:169 struct hugr_llvm::custom::int::IntTypesCodegenExtension, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/int.rs:150 struct hugr_llvm::custom::rotation::RotationCodegenExtension, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/rotation.rs:30 --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/trait_method_added.ron Failed in: trait method hugr_llvm::custom::CodegenExtension::add_extension in file /tmp/.tmpGjujM0/hugr-llvm/src/custom.rs:41 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/trait_method_missing.ron Failed in: method extension of trait CodegenExtension, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom.rs:38 method supported_consts of trait CodegenExtension, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom.rs:44 method llvm_type of trait CodegenExtension, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom.rs:50 method emitter of trait CodegenExtension, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom.rs:58 method load_constant of trait CodegenExtension, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom.rs:68 --- failure trait_missing: pub trait removed or renamed --- Description: A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/trait_missing.ron Failed in: trait hugr_llvm::emit::EmitOp, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/emit.rs:45 trait hugr_llvm::custom::prelude::PreludeCodegen, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/custom/prelude.rs:52 trait hugr_llvm::fat::FatExt, previously in file /tmp/.tmpu0X9jI/hugr-llvm/src/fat.rs:313 --- failure trait_no_longer_object_safe: trait no longer object safe --- Description: Trait is no longer object safe, which breaks `dyn Trait` usage. ref: https://doc.rust-lang.org/stable/reference/items/traits.html#object-safety impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/trait_no_longer_object_safe.ron Failed in: trait CodegenExtension in file /tmp/.tmpGjujM0/hugr-llvm/src/custom.rs:38 ``` <details><summary>Changelog</summary> <blockquote> ## [0.6.0](CQCL/hugr-llvm@v0.5.1...v0.6.0) - 2024-10-21 ### Bug Fixes - Conversion operations having poison results ([#131](CQCL/hugr-llvm#131)) ### New Features - [**breaking**] Allow extension callbacks to have non-`'static` lifetimes ([#128](CQCL/hugr-llvm#128)) - [**breaking**] Support `tket2.rotation.from_halfturns_unchecked` ([#133](CQCL/hugr-llvm#133)) ### Refactor - [**breaking**] remove trait emit op ([#104](CQCL/hugr-llvm#104)) - [**breaking**] rework extensions interface ([#119](CQCL/hugr-llvm#119)) - [**breaking**] move packaged extensions from `crate::custom` to `crate::extension` ([#126](CQCL/hugr-llvm#126)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).

cqc-alec and others added 5 commits June 2, 2023 16:06

[DONOTMERGE] Define the SimpleReplace API.

7c00a7a

Not to be merged since it assumes multiports, which are not yet reflected in the spec.

Correct order of maps.

2b49af4

Exclude the input and output nodes under P.

9e97fa2

Clarify wording.

d06a623

Implement SimpleReplace.

b5aceb8

cqc-alec requested review from acl-cqc and lmondada June 5, 2023 09:28

acl-cqc reviewed Jun 5, 2023

View reviewed changes

cqc-alec added 4 commits June 5, 2023 13:53

Use (hopefully) faster method for checking that node exists.

d73af14

Neaten code.

1c7235a

Check for errors before mutating hugr.

eb1dc3a

Iterate using references.

0531553

aborgna-q requested changes Jun 5, 2023

View reviewed changes

cqc-alec added 17 commits June 5, 2023 16:02

Merge branch 'main' into simple-replace-impl.1

f0113e2

Collect vector of Node instead of NodeIndex.

46fe94e

Add TODO.

5663d64

Rename fields of SimpleReplacement.

9833084

Merge branch 'main' into simple-replace-impl.1

04af0e9

Better variable names.

e731b5d

Merge branch 'main' into simple-replace-impl.1

1a71d4d

Update test code after merge of new builder API.

6b5d781

Update docstrings.

3004617

Update with DFG-rooted hugr in SimpleReplace.

6e783e9

Shorten lines with comments.

ce87c8b

Add ASCII art.

c1e804f

Use exactly_one().

11bc314

Move module docstring to top of implementation file.

ca43b5a

Simplify check.

084c90b

Fix up names in comments.

3afebaa

Remove useless "?" operator.

524fda6

cqc-alec added 5 commits June 7, 2023 13:05

Fix docstring.

0c035a0

Add test for empty wires.

0bc4c59

Fix spec to handle empty wires.

5f7ed93

Implement fixed spec.

51cc254

Merge branch 'main' into simple-replace-impl.1

b7170ef

cqc-alec marked this pull request as ready for review June 7, 2023 14:53

cqc-alec requested a review from acl-cqc June 7, 2023 14:53

cqc-alec added 3 commits June 7, 2023 16:05

Merge branch 'main' into simple-replace-impl.1

a200e8c

Fix up following multiports merge.

ddbb8b8

Change "region" to "parent".

f801078

cqc-alec requested a review from aborgna-q June 8, 2023 08:53

aborgna-q reviewed Jun 8, 2023

View reviewed changes

cqc-alec added 5 commits June 8, 2023 11:48

Don't call ok() before unwrap().

ebab636

Simplify check.

64a5164

Simplify collection of children.

46a02ca

Use last() for clarity.

be5dc52

Merge branch 'main' into simple-replace-impl.1

3da2bc2

cqc-alec requested a review from aborgna-q June 8, 2023 11:08

aborgna-q approved these changes Jun 8, 2023

View reviewed changes

cqc-alec added 2 commits June 8, 2023 14:17

Merge branch 'main' into simple-replace-impl.1

e7ce0bb

Use different variable names to avoid confusion with description below.

f216899

cqc-alec merged commit 3662b73 into main Jun 8, 2023

cqc-alec deleted the simple-replace-impl.1 branch June 8, 2023 13:31

aborgna-q added a commit that referenced this pull request Jun 8, 2023

Fix failing CI

ba79985

#139 wasn't compatible with #114

aborgna-q mentioned this pull request Jun 8, 2023

Fix failing CI #141

Merged

aborgna-q added a commit that referenced this pull request Jun 8, 2023

Fix failing CI (#141)

0ac99ff

#139 wasn't compatible with #114

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `SimpleReplace` #114

Implement `SimpleReplace` #114

cqc-alec commented Jun 5, 2023

acl-cqc left a comment

acl-cqc Jun 5, 2023

acl-cqc Jun 5, 2023

acl-cqc Jun 5, 2023

acl-cqc Jun 5, 2023

acl-cqc Jun 5, 2023

acl-cqc Jun 5, 2023

acl-cqc Jun 5, 2023

acl-cqc Jun 5, 2023

aborgna-q left a comment

cqc-alec commented Jun 7, 2023

cqc-alec commented Jun 7, 2023

aborgna-q left a comment

aborgna-q Jun 8, 2023

cqc-alec Jun 8, 2023

aborgna-q Jun 8, 2023

cqc-alec Jun 8, 2023

aborgna-q Jun 8, 2023

aborgna-q Jun 8, 2023

aborgna-q Jun 8, 2023

cqc-alec Jun 8, 2023

cqc-alec commented Jun 8, 2023

		let n_node = Node { index: *n_index };
		let op: &OpType = r.n.get_optype(n_node);

	let n_node = Node { index: *n_index };
	let op: &OpType = r.n.get_optype(n_node);
	let op: &OpType = r.n.get_optype((*n_index).into());


		const QB: SimpleType = SimpleType::Linear(LinearType::Qubit);

		/// Creates a hugr with a DFG.

		- a map $\nu\_\textrm{inp}: \textrm{inp}\_H(T \setminus \\{\texttt{Input}\\}) \to \textrm{inp}\_{\Gamma}(S)$;
		- a map $\nu_\textrm{out}: \textrm{out}_{\Gamma}(S) \to \textrm{out}_H(T \setminus \\{\texttt{Output}\\})$.

	h.apply_simple_replacement(r).ok();
	h.apply_simple_replacement(r).unwrap();

Implement SimpleReplace #114

Implement SimpleReplace #114

Conversation

cqc-alec commented Jun 5, 2023

acl-cqc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aborgna-q left a comment

Choose a reason for hiding this comment

cqc-alec commented Jun 7, 2023

cqc-alec commented Jun 7, 2023

aborgna-q left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cqc-alec commented Jun 8, 2023

Implement `SimpleReplace` #114

Implement `SimpleReplace` #114