Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor (split or rename) Signature #691

Closed
acl-cqc opened this issue Nov 14, 2023 · 1 comment · Fixed by #714
Closed

Refactor (split or rename) Signature #691

acl-cqc opened this issue Nov 14, 2023 · 1 comment · Fixed by #714
Assignees

Comments

@acl-cqc
Copy link
Contributor

acl-cqc commented Nov 14, 2023

  • At the least, make Signature store an Option rather than FunctionType, so we can return a Signature for non-dataflow ops
  • But, there are many things called signature (FunctionType's, Signature's, etc.), which quickly confuses as to what is what; so some renaming is in order
  • Consider replacing NodeType::signature(&self) -> Signature with a simple getter for input_extensions (returning Option<ExtensionSet>); the rest of the info in the old signature() is available from op_signature() if required
@acl-cqc
Copy link
Contributor Author

acl-cqc commented Nov 16, 2023

Note this substantially addressed by #700; Signature can probably now be removed altogether, following #692.

@acl-cqc acl-cqc self-assigned this Nov 16, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 28, 2023
Main uses were removed in #700 and #692 - so just update tests that were
using Signature to store two things together.

closes #691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant