Pr433 #435
Pr433 #435
Conversation
Signed-off-by: Daniel Alvarez-Coello <[email protected]>
Signed-off-by: Erik Jaegervall <[email protected]>
|
@jdacoello - Can you check the changes in the commit I added on top, if they looks ok. If so I can merge this PR and close yours, or if you prefer you can incorporate the changes from this PR into yours. |
|
They seem to be ok. You can go ahead and merge this PR and close the other one. I forgot that I changed a little the doc strings and the order in which elements appear in the resulting graphql schema. Apparently, that is why the tests were not passing. Thanks for addressing that and updating the expected files. |
| pass | ||
|
|
||
|
|
||
| def get_instance_root(root: VSSNode, depth: int = 1) -> tuple[VSSNode, int]: |
There was a problem hiding this comment.
The go exporter initially defined that one. Should be removed from the go exporter then
| raise NoInstanceRootException() | ||
|
|
||
|
|
||
| def add_children_map_entries(root: VSSNode, fqn: str, replace: str, map: dict[str, str]) -> None: |
| add_children_map_entries(child, fqn, replace, map) | ||
|
|
||
|
|
||
| def get_instance_mapping(root: VSSNode | None) -> dict[str, str]: |
There was a problem hiding this comment.
This PR is merged now - are you interested in doing the cleanup in a new PR?
Same as #433 but trying to fix build errors