Cice grid generation #6
Conversation
|
I tried to run the tests ... it looks like they rely on some test data which doesn't exist anymore. I get a 404 error trying to download from this link: http://s3-ap-southeast-2.amazonaws.com/dp-drop/esmgrids/test/test_data.tar.gz |
|
@aekiss & @ezhilsabareesh8 Can you review please? |
Bump :) |
esmgrids/mom_grid.py
Outdated
| # The angle of rotation is a corner cell centres and applies to | ||
| # both t and u cells. | ||
| angle_t = angle_dx[2::2, 2::2] | ||
|
|
There was a problem hiding this comment.
I think it would be add a comment why we are changing the index to 1::2, 1::2
There was a problem hiding this comment.
I don't know how to write a concise comment to say it ... The rest of the file is uncommented so i just followed that style !
|
@anton-seaice I suggest you drop the last three commits and rebase onto the latest |
|
@anton-seaice, I'm happy to do a review once you've brought in the relevant parts of COSIMA/om3-utils#5 (i.e. the additional provenance metadata and the tests) |
anton-seaice
force-pushed
the
cice_grid_generation
branch
from
e5791f1 to
9a1682f
Compare
|
@dougiesquire I think this is mostly done. Its a bit messy, which I will try and tidy up. |
anton-seaice
force-pushed
the
cice_grid_generation
branch
from
12c0ad1 to
f500eb7
Compare
|
@anton-seaice I'm not working today, but let me know when you're done making changes and I'll do a review first thing tomorrow |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
One could add a check to stop the code if the file is being generated with uncommitted changes and issue a warning if it's not a tagged release. |
Sure, I'll do that now |
|
@anton-seaice, one more PR from me. Then IMO we're ready for a final review and merge |
There was a problem hiding this comment.
LGTM! Thanks for this @anton-seaice - a big and important chunk of work
|
Thanks @anton-seaice and everyone - great work! |
This allows much stricter checking of angles in the ESMF files compared to the model grid files (per COSIMA/access-om3#144)
This allows much stricter checking of angles in the ESMF files compared to the model grid files (per COSIMA/access-om3#144)
This allows much stricter checking of angles in the ESMF files compared to the model grid files (per COSIMA/access-om3#144)
This allows much stricter checking of angles in the ESMF files compared to the model grid files (per COSIMA/access-om3#144)
This allows much stricter checking of angles in the ESMF files compared to the model grid files (per COSIMA/access-om3#144)
This allows much stricter checking of angles in the ESMF files compared to the model grid files (per COSIMA/access-om3#144)
This allows much stricter checking of angles in the ESMF files compared to the model grid files (per COSIMA/access-om3#144)
This allows much stricter checking of angles in the ESMF files compared to the model grid files (per COSIMA/access-om3#144)
This allows much stricter checking of angles in the ESMF files compared to the model grid files (per COSIMA/access-om3#144)
This allows much stricter checking of angles in the ESMF files compared to the model grid files (per COSIMA/access-om3#144)
This allows much stricter checking of angles in the ESMF files compared to the model grid files (per COSIMA/access-om3#144)
Companion pull request to COSIMA/om3-scripts#8EDIT: This PR also adds tests. See COSIMA/om3-utils#5 for full scope of changes and review