-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Make your own intake datastore recipe #440
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I request Dougie's review but it really needs review from a non-intake expect too :) FYI @marc-white |
My vote is let's not delete yet. I would guess 80% or so of COSIMA are still using the cookbook, and many of the Recipes still use it. How about we leave it up for another 6-12 months and then reassess? |
As Navid says - you can always find it in the history. But having it in the main branch means it goes in the "readthedocs" too. Maybe just add a note at the top of the make your own cookbook recipe to refer to the new recipe? |
I'm not sure I understand your reasoning @adele-morrison. The tutorial is about how to make your own database for the cookbook, not about using the already existent ones. If someone is going to the trouble of indexing an experiment for the first time, I think it would be better to nudge them towards intake. It seems kind of mean to help them learn an already outdated skill. |
if intake is ready to be used, then let's delete all cookbook stuff! I do have that habit myself (eg to avoid moving to new tools). For example, I'm still using but I also see @adele-morrison's point so as a mid-way ground I'd say we keep it BUT:
|
I agree. And the people who do need to find it they'll ask around or dig into Github and find it. I think mostly it's the fear of letting go? I think that if we feel that intake is ready to be used (not sure about that as experienced users like @julia-neme seemed to run into a lot of issues!) then we should brave the fear and let go. I'm saying this but I'm also happy with the intermediate solution I suggested above. |
I think we should at least have 100% of the Recipes converted to Intake first before deleting it. If there are still recipes that we can't guarantee work with Intake, then people will still need it. But yes, let's warn new users not to use it. |
826036b
to
12e8157
Compare
Co-authored-by: dougiesquire <[email protected]>
12e8157
to
60cf747
Compare
I think I will merge this unless anyone else wants to jump in and review :) |
Merge! |
Sorry I didn't get to review this, it landed right while I was being blasted with COVID :( |
No need to apologize! The community got your back! |
Adding a recipe to make your own intake-esm datastore (n.b. the intake catalog is a collection of datastores, there is one datastore for one experiment)
Shall we delete the "Make your own cookbook" recipe ? (There was previous inconclusive discussion #376)