Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ContributedExamples; all examples are Documented! #407

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Jul 4, 2024

This PR removes the old and outdated ContributedExamples and renames the DocumentedExamples to simply Examples setting up a new standard in the recipes.

All examples are documented -- no need to call them DocumentedExamples!

Closes #330

@navidcy navidcy requested review from adele-morrison, anton-seaice and a team July 4, 2024 05:30
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@adele-morrison adele-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do you mean we have to wait until all the existing PRs are merged until we can do this one? That may be never?

@navidcy
Copy link
Collaborator Author

navidcy commented Jul 5, 2024

Look... I thought about that but then I changed my mind. I deleted the comment ;)
No I'm merging. We move on with life :)

@navidcy navidcy merged commit dd5083c into main Jul 5, 2024
3 checks passed
@navidcy navidcy deleted the ncc/cleanup branch July 5, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Delete Contributed Examples
2 participants