Patch the CMEPS history output so that it can be used. Currently hist… #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aekiss
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Thanks @anton-seaice that looks good. Have you tested it to confirm it resolved this issue?
Also your comment above seems backwards - I think
the implementation of history output with type double is incomplete. Change to type single/real
should be
the implementation of history output with type float is incomplete. Change to type double
to avoid confusing our future selves
…ory output is full of _fillValue, as the implementation of history output with type float is incomplete. Change to type double.
anton-seaice
force-pushed
the
patch_CMEPS_history
branch
from
da86078 to
a27ec3d
Compare
|
I did get useful mediator output at some point by doing this. I will re-test with this exact patch to be sure before merging. I thin I fixed the commit comment :) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #44
@aekiss - I'm not sure if you agree on scope, so assigning to you :)