Replace SIGNATURE
with mgard::SIGNATURE
#195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the signature macro defined in
include/mgard-x/Metadata.hpp
with themgard::SIGNATURE
constant defined ininclude/format.hpp
.@JieyangChen7, please review this commit. In addition to the signature switch, it also removes the
Metadata::signature
data member (since the only valid value ismgard::SIGNATURE
). I can keep that member if you prefer.@qliu21, please don't merge this pull request yet. I'll rebase on top of
fix-installation-paths
once you merge #194.