Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Android 15 instead of Android 14 #64

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

tegridyfarmer
Copy link
Contributor

@tegridyfarmer tegridyfarmer commented Jan 17, 2025

This should target Android 15 instead of Android 14 by changing the targetsdk from 34 to 35.

Related to issue: #58

This should target Android 15 instead of Android 14 by changing the targetsdk from 34 to 35.
@CNugteren
Copy link
Owner

Could you re-add the .github folder?

@tegridyfarmer
Copy link
Contributor Author

tegridyfarmer commented Jan 21, 2025

Yes, I will try and do that today if I have some time. This is my first pull request, so I did not exactly know how it worked

@tegridyfarmer
Copy link
Contributor Author

I have re-added the .github folder.

@tegridyfarmer
Copy link
Contributor Author

Do you want to merge this PR?
Otherwise I can also close it.

@CNugteren
Copy link
Owner

Please keep it open, I plan to merge it. However, I want to test it first on Android 15 to make sure it actually works fine. But to do so, I need an Android Virtual Device with Android 15 but I have some problems with the virtual device tool on my laptop. I can probably find some time within the next few days to fix it, then test it, and then we can merge it in.

@CNugteren
Copy link
Owner

This was tested on an Android 15 virtual device and I didn't see any issues, so let's merge this in 👍

@CNugteren CNugteren merged commit bf67c83 into CNugteren:master Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants