Upgrade to useDApps/core 1.2.11 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because chainId returns undefined while switching the provider on useEthers activate/deactivate.
wagyu298
force-pushed
the
upgrade-usedapps-1.2.11
branch
from
dc07f0d to
26b281d
Compare
ms76
reviewed
Aug 23, 2023
There was a problem hiding this comment.
I’ve checked your fix. There were 2 points where I think await is missing, although they are not part of this fix.
One is commented and the other is below.
https://github.com/CNNouns/cnnouns-monorepo/pull/23/files#diff-aefeb8faf6b9330978ae529f732f9d79575267e925c501f429f462be0b76bab8R137
| @@ -59,8 +59,7 @@ | |||
| "redux": "^4.1.0", | |||
| "redux-devtools-extension": "^2.13.9", | |||
| "remark-breaks": "^3.0.1", | |||
| "web-vitals": "^1.0.1", | |||
| "react-transition-group": "^4.4.5" | |||
| nounsAuctionHouseContract, | ||
| undefined, | ||
| library && 'getSigner' in library ? library.getSigner() : undefined, | ||
| ); | ||
| const gasLimit = await contract.estimateGas.settleCurrentAndCreateNewAuction(...args); | ||
| settleAuction(...args, { |
|
#25 merged, test passed. |
|
@ms76 Thank you for your code reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce
eth_chainIdAPI call by using StaticJsonRpcProvider.useDApps/core 1.0.8 or later uses StaticJsonRpcProvider for readOnlyUrls.
See ethers-io/ethers.js#901 for more details.