Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the dqm file #53

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Store the dqm file #53

merged 3 commits into from
Jan 14, 2019

Conversation

apsallid
Copy link
Contributor

An option is added (--keepDQMfile) so that, if used, at the RECO step the DQM file will also be stored locally or in eos in a separate folder.

README.md Outdated Show resolved Hide resolved
@apsallid
Copy link
Contributor Author

Hi @rovere , @clelange ,

I just wanted to clarify that the DQM file that is stored with this PR is in edm format. The harvesting step is not executed in order to save the DQM file in plain ROOT format.
I thought in this way this would be more generic, but if you feel like we should add the harvesting step I can work on that. However, that may be useful for me, but for others it may add more unnecessary complexity to the repository. Personally, I just add an extra cmsDriver command in the RECO step in the SubmitFileGSD.sh script, which of course is not the correct way to do since all the options are hardcoded, but it does the job.

@clelange
Copy link
Contributor

@apsallid - I think we should just use whatever works best for you, you're the main user of this feature. If anyone else wants to use this, we can re-discuss.
@rovere - Are there any short-term plans from your side or anyone else you could think of who might want to use anything beyond what Andreas has implemented

@rovere
Copy link
Contributor

rovere commented Jan 14, 2019

@clemens, for the moment I think this PR is more than enough.

@clelange clelange merged commit d1854d3 into CMS-HGCAL:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants