Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: View current day's Habits #39

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Feature: View current day's Habits #39

merged 3 commits into from
Oct 25, 2021

Conversation

mosaicthej
Copy link
Contributor

  • Make Habit.isInDay() in Habit.java
  • Implement the checkBox feature in TodayHabitsFragment.java

Closes #7

@mosaicthej
View current day's Habits
614930a 
- Make Habit.isInDay() in Habit.java
- Implement the checkBox feature in TodayHabitsFragment.java

Closes #7
@mosaicthej mosaicthej requested review from a user, cbebe, ashutoshlamba and CxLeo October 25, 2021 21:22
cbebe
cbebe requested changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@cbebe cbebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just remove the constants in Habit.java since it's not needed.

cbebe
cbebe approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@cbebe cbebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@cbebe cbebe merged commit 7869fba into master Oct 25, 2021
@cbebe cbebe mentioned this pull request Oct 26, 2021
Merged
@cbebe cbebe deleted the feat/view-todays-habits branch October 26, 2021 00:49
@cbebe cbebe restored the feat/view-todays-habits branch October 26, 2021 00:50
@cbebe cbebe deleted the feat/view-todays-habits branch October 26, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbebe cbebe cbebe approved these changes

@ashutoshlamba ashutoshlamba Awaiting requested review from ashutoshlamba

@CxLeo CxLeo Awaiting requested review from CxLeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

US 01.07.01 View current day's Habits - 5 pts
2 participants
@mosaicthej @cbebe