🎨 refactor: Make the ids in captain descriptive

CMP26Projects · Dec 27, 2023 · f26fa83 · f26fa83
1 parent 11ad7de
commit f26fa83
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/server/controllers/captain.controller.js b/server/controllers/captain.controller.js
@@ -89,14 +89,14 @@ const captainController = {
     getCaptain: async (req, res) => {
         try {
             // Extract the captain ID from the request params
-            const { id } = req.params
+            const { captainId } = req.params
 
             // Query on the database to get that captain info
             const result = await db.query(
                 `SELECT *
                 FROM "Captain"
                 WHERE "captainId" = $1`,
-                [id]
+                [captainId]
             )
 
             // If captain doesn't exist return an error message
@@ -124,10 +124,10 @@ const captainController = {
     // @access  Private
     setCaptainType: async (req, res) => {
         try {
-            const { id } = req.params
+            const { captainId } = req.params
             const { type } = req.body
 
-            if (!id) {
+            if (!captainId) {
                 return res.status(400).json({
                     error: "Please enter a valid id",
                 })
@@ -146,7 +146,7 @@ const captainController = {
                 WHERE "captainId" = $1
                 RETURNING *
             `,
-            [id, type])
+            [captainId, type])
 
             res.status(200).json({
                 message: "Successful update",

diff --git a/server/routes/captain.route.js b/server/routes/captain.route.js
@@ -9,7 +9,7 @@ captainRouter.get(
     '/sector/:baseName/:suffixName',
     captainController.getCaptainsInSector
 )
-captainRouter.get('/:id', captainController.getCaptain)
-captainRouter.patch('/:id', captainController.setCaptainType)
+captainRouter.get('/:captainId', captainController.getCaptain)
+captainRouter.patch('/:captainId', captainController.setCaptainType)
 
 export default captainRouter