Fix WYSIWYG filed not working in a group #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the WYSIWYG field isn't working in a group.
Description
When refactoring the WYSIWYG field in 7bb887c#diff-73510adb75ef05f23da2023345b5cf0dR49 the issue was introduced.
'wp-util', 'cmb2-wysiwyg'should bearray( 'wp-util', 'cmb2-wysiwyg' ).Motivation and Context
I use the wysiwyg field in a group and just noticed it stopped working, while it was working before.
Risk Level
I think the risk level should be low.
Testing procedure
Add a wysiwyg field to a group, it'll be displayed as a textarea, tinyMCE isn't initiated on it.
Types of changes
Checklist: