Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in Macros.hpp #706

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Fix typo in Macros.hpp #706

merged 1 commit into from
Feb 23, 2022

Conversation

RangeMachine
Copy link
Contributor

No description provided.

@yuriy-odonnell-epic
Copy link

This issue was found thanks to error C4668: '__MSVC_LANG' is not defined as a preprocessor macro, replacing with '0' for '#if/#elif' compiler diagnostic. Our codebase happens to enable the relevant warning.

@henryiii
Copy link
Collaborator

I'd like to know how to enable that warning. :)

@henryiii henryiii merged commit 5915938 into CLIUtils:main Feb 23, 2022
@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Feb 23, 2022
@yuriy-odonnell-epic
Copy link

#pragma warning (error : 4668) this could be one way (compiler explorer).

@henryiii henryiii mentioned this pull request Feb 23, 2022
Closed
@henryiii henryiii removed needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RangeMachine @yuriy-odonnell-epic @henryiii