Return empty string in Option::get_name() for hidden options #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skannan89
commented
Oct 14, 2019
include/CLI/Option.hpp
Outdated
| @@ -627,6 +627,8 @@ class Option : public OptionBase<Option> { | |||
| std::string get_name(bool positional = false, //<[input] Show the positional name | |||
| bool all_options = false //<[input] Show every option | |||
| ) const { | |||
| if (detail::to_lower(get_group()).empty()) | |||
There was a problem hiding this comment.
Don't think we need detail::to_lower() call.
There was a problem hiding this comment.
wouldn't appear so if we are just checking empty()
|
Please rebase and force-with-lease, please. CI should be fixed. You might need to run pre-commit, but unlikely. I'll do it if you need me to. |
|
Thanks for fixing CI. Added a few more commits. |
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 3175 3177 +2
=====================================
+ Hits 3175 3177 +2
Continue to review full report at Codecov.
|
|
Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332