-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build testing #277
Build testing #277
Conversation
6f83499
to
e4e5d6f
Compare
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 2782 2782
=====================================
Hits 2782 2782 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 2782 2782
=====================================
Hits 2782 2782
Continue to review full report at Codecov.
|
f12f7e9
to
e4ded0b
Compare
6664079
to
b8869ef
Compare
b8869ef
to
b92d293
Compare
99648ce
to
5b2819e
Compare
azure-pipelines.yml
Outdated
pool: | ||
vmImage: 'ubuntu-16.04' | ||
steps: | ||
- template: .ci/azure-steps.yml | ||
- script: scripts/check_style_docker.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the other format check be dropped. Seems a little redundant to have both, or are they checking different things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be slowly reducing our usage of non-Azure CI, so yes. I could probably go ahead and drop that in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually still only checking "clang-tidy" on Travis. I'll need to move that in here in the future.
fbc0028
to
03b6ad3
Compare
03b6ad3
to
91144e6
Compare
The original implementation (and many implementations of
BUILD_TESTING
, I think) has an issue; if you setBUILD_TESTING
in a parent project, it gets picked up unconditionally in a child project. This makesBUILD_TESTING
be ignored if CLI11 is a child project;CLI11_TESTING
will still control it if a parent project really wants a child project to build its tests. If you setBUILD_TESTING
with CLI11 as the parent project, this will overrideCLI11_TESTING
, as it does now.Based on plans mentioned in #273, follows up on #183. This may be the last change for 1.8.
Also adds clang-format testing on Azure, along with GCC 4.7, 9, Clang 3.4, 8. You can now force libc++ if this is the master project.
Drops experimental optional auto-support, it can be fragile.