Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build testing #277

Merged
merged 14 commits into from
May 14, 2019
Merged

Build testing #277

merged 14 commits into from
May 14, 2019

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented May 11, 2019

The original implementation (and many implementations of BUILD_TESTING, I think) has an issue; if you set BUILD_TESTING in a parent project, it gets picked up unconditionally in a child project. This makes BUILD_TESTING be ignored if CLI11 is a child project; CLI11_TESTING will still control it if a parent project really wants a child project to build its tests. If you set BUILD_TESTING with CLI11 as the parent project, this will override CLI11_TESTING, as it does now.

Based on plans mentioned in #273, follows up on #183. This may be the last change for 1.8.

Also adds clang-format testing on Azure, along with GCC 4.7, 9, Clang 3.4, 8. You can now force libc++ if this is the master project.

Drops experimental optional auto-support, it can be fragile.

Main Project CLI11_TESTING unset CLI11_TESTING OFF CLI11_TESTING ON
BUILD_TESTING default ✔️ ✔️
BUILD_TESTING OFF ✔️
BUILD_TESTING ON ✔️ ✔️
Sub Project CLI11_TESTING unset CLI11_TESTING OFF CLI11_TESTING ON
BUILD_TESTING unset ✔️
BUILD_TESTING OFF ✔️
BUILD_TESTING ON ✔️

@henryiii henryiii force-pushed the henryiii-build-testing branch from 6f83499 to e4e5d6f Compare May 11, 2019 15:28
@codecov
Copy link

codecov bot commented May 11, 2019

Codecov Report

Merging #277 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #277   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        2782   2782           
=====================================
  Hits         2782   2782

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be526e...e4e5d6f. Read the comment docs.

@codecov
Copy link

codecov bot commented May 11, 2019

Codecov Report

Merging #277 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #277   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        2782   2782           
=====================================
  Hits         2782   2782
Impacted Files Coverage Δ
include/CLI/Timer.hpp 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be526e...a3113e4. Read the comment docs.

@henryiii henryiii force-pushed the henryiii-build-testing branch 4 times, most recently from f12f7e9 to e4ded0b Compare May 11, 2019 18:53
@henryiii henryiii force-pushed the henryiii-build-testing branch 10 times, most recently from 6664079 to b8869ef Compare May 11, 2019 22:09
@henryiii henryiii force-pushed the henryiii-build-testing branch from b8869ef to b92d293 Compare May 11, 2019 22:39
@henryiii henryiii force-pushed the henryiii-build-testing branch from 99648ce to 5b2819e Compare May 12, 2019 11:16
@henryiii henryiii requested a review from phlptp May 13, 2019 08:47
CHANGELOG.md Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
pool:
vmImage: 'ubuntu-16.04'
steps:
- template: .ci/azure-steps.yml
- script: scripts/check_style_docker.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the other format check be dropped. Seems a little redundant to have both, or are they checking different things?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be slowly reducing our usage of non-Azure CI, so yes. I could probably go ahead and drop that in this PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually still only checking "clang-tidy" on Travis. I'll need to move that in here in the future.

@henryiii henryiii force-pushed the henryiii-build-testing branch from fbc0028 to 03b6ad3 Compare May 14, 2019 10:21
@henryiii henryiii force-pushed the henryiii-build-testing branch from 03b6ad3 to 91144e6 Compare May 14, 2019 10:24
@henryiii henryiii merged commit 433fd91 into master May 14, 2019
@henryiii henryiii deleted the henryiii-build-testing branch May 14, 2019 13:33
@henryiii henryiii added this to the v1.8 milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants