eccodes dependency update #947
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanuel-schmid
changed the title
|
Hi @emanuel-schmid, I'm not at all in the know about eccodes and the grib-files being read. I avoided adding eccodes to the dependencies in summer 2020 because it's not pure Python, and because I was only reading minimal amounts of bufr files. I suppose that @ThomasRoosli is much closer to the subject at hand... |
|
@mmyrte 👍 fair enough. thanks for the note! |
in order to avoid circular imports
|
@emanuel-schmid Any plans to finish this PR? Are more inputs needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This PR fixes #678
PR Author Checklist
develop)PR Reviewer Checklist