Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled hazard tutorial (some plots were missing) #919

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

ValentinGebhart
Copy link
Collaborator

Changes proposed in this PR:

PR Author Checklist

PR Reviewer Checklist

Copy link
Member

@peanutfun peanutfun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readthedocs build fails

"metadata": {},
"outputs": [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readthedocs build fails because at least one output cell is missing. I found this one. Apparently, our doc setup fails if output gets deleted (or, at least, if we delete it in VSCode. The outputs section should never be deleted). The remedy is to re-run this cell, or the entire notebook for good measure. Afterward, commit the notebook again.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ok I did rerun the entire notebook. Can you check the readthedocs build again? I can also check but I don't know where.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-07-17 at 14 46 13

@peanutfun peanutfun merged commit abe479c into develop Jul 17, 2024
18 checks passed
@ValentinGebhart ValentinGebhart deleted the compile_haz_tutorial branch July 17, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants