-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split tropical_cyclone module #911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work! It is now much easier to get an overview of the module. I have suggestions that should fix some linter issues.
The change in module structure broke the module documentation. You will have to add two automodule
directives for the new submodules in the last section of doc/climada/climada.hazard.rst
. If you are confused say so, and I will try to fix it before merging. Thanks! 🙏
Co-authored-by: Lukas Riedel <[email protected]>
Co-authored-by: Lukas Riedel <[email protected]>
Co-authored-by: Lukas Riedel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestions. I agree with them. I am happy to further discuss the exposed constants.
Changes proposed in this PR:
This PR fixes no specific issue, but is was mentioned in the discussion of #846
PR Author Checklist
develop
)PR Reviewer Checklist