Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add polynomial s shape impact function #878
Add polynomial s shape impact function #878
Changes from 9 commits
2bf9176
18c43c7
40779e9
c2664c0
920bb2f
c762325
62e3034
24238e7
3fa55db
133c834
0e10eb6
b355c0a
8dbe611
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 277 in climada/entity/impact_funcs/base.py
Jenkins - WCR / Pylint
too-many-arguments
Raw output
Check warning on line 291 in climada/entity/impact_funcs/base.py
Jenkins - WCR / Pylint
line-too-long
Raw output
Check warning on line 292 in climada/entity/impact_funcs/base.py
Jenkins - WCR / Pylint
line-too-long
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check actual error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the correction! Why should we priorize using
assertRaisesRegex
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it tests the actual error message.
assertRaises
would succeed with anyValueError
thrown, but you want to test for a specific one here.Note that this is basically a shortcut for the idiom we were using so far:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes total sense, thanks!