Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix lon_bounds returning range > 360 degrees #859

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

ChrisFairless
Copy link
Collaborator

This PR fixes #858

PR Author Checklist

PR Reviewer Checklist

@ChrisFairless ChrisFairless requested a review from tovogt March 13, 2024 13:39
@ChrisFairless
Copy link
Collaborator Author

Tests are failing: it looks like these tests also failed in last night's Jenkins build so I'm hoping this is unrelated.

Copy link
Collaborator

@tovogt tovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks for the fix!

@tovogt tovogt merged commit d2f2997 into develop Mar 14, 2024
2 of 11 checks passed
@emanuel-schmid emanuel-schmid deleted the bugfix/lon_bounds branch March 14, 2024 11:38
gdeskos pushed a commit to gdeskos/climada_python that referenced this pull request Sep 16, 2024
* Bugfix coordinates.lon_bounds for edge case returning >360 range

See issue CLIMADA-project#858

* lon_bounds: refactor

---------

Co-authored-by: Thomas Vogt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants