-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all uses of Tag from climada/engine #743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress on the quest towards removing the Tag
from CLIMADA. Thanks!
Co-authored-by: Chahan M. Kropf <[email protected]>
@chahank There is another issue: The
This way, we are not backward compatible but users know how to fix the issue. |
…roject/climada_python into remove-tag-from-engine
Excellent idea! Although I think we do not need to make the error message. Most users will not directly use this method anyway imho. |
Alright, even easier 🙌 |
Oh, and probably you should go through the documentation and check whether the |
@chahank I removed the |
Excellent, looks good to me! |
Thanks for the input, merging now! |
Changes proposed in this PR:
Tag
fromclimada/engine/
PR Author Checklist
develop
)PR Reviewer Checklist