-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module for calibrating impact functions #692
Conversation
# Conflicts: # script/jenkins/branches/Jenkinsfile # tests_runner.py
Personal conversation with @chahank:
|
Hi, |
This might come in the future. It is not so trivial to integrate. Maybe there first will have to be a MultiImpactCalc module. Please feel free to contribute if you would like to see more features. |
Use negative cost function as target function in BayesianOptimizer Co-authored-by: Thomas Vogt <[email protected]>
After another discussion with @chahank: We will support lists of hazard and exposure objects as inputs. These lists must have the same length. If lists are given as input, the cost function will receive a list of corresponding impact objects. Users will have to adapt their cost functions accordingly |
--------- Co-authored-by: Chahan M. Kropf <[email protected]> Co-authored-by: Schmid Timo <[email protected]>
Hey! Some useful context, just in case you've not looked at this already. I ran the tutorial and plotted the calibrated impact function for the NA1 region against the functions given by the out-of-the-box Emanuel and the regionally-calibrated Eberenz functions: It's quite a change. Any idea why? Looking at the input data loaded at the start of the analysis, it hasn't been changed for at least three years, so I assume it dates back to the Eberenz calibrations. Given the uncertainty shown in those original calibrations (see below and Fig 5 of https://nhess.copernicus.org/articles/21/393/2021/ ) I assume it's entirely due to the cost function? Code to add these curves:
|
@ChrisFairless Thanks for reporting these findings! To be sure it's due to the cost function, we have to select the exact same events from the EM-DAT database, use the exact same hazard footprints and exposures, and also calibrate the same parameters as Eberenz et al. The tutorial uses only a subset of the EM-DAT cases in the NA basin, and it calibrates two parameters of the function. So there are plenty of reasons why the results may differ from the previously calibrated functions, apart from the cost function. |
Add a generalized (!) module for calibrating impact functions.
scipy.minimize
.bayesian-optimization
package.BayesianOptimizer
.This PR fixes #680
PR Author Checklist
develop
)PR Reviewer Checklist