Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve lines disaggregation method #679

Merged
merged 23 commits into from
Mar 27, 2023
Merged

Improve lines disaggregation method #679

merged 23 commits into from
Mar 27, 2023

Conversation

chahank
Copy link
Member

@chahank chahank commented Mar 23, 2023 •
edited by peanutfun
Loading

Changes proposed in this PR:

  • The method to disaggregate lines was updated to better conserve the total length of all lines on average.
  • Accordingly, some of the tests were adapted.

PR Author Checklist

PR Reviewer Checklist

@chahank chahank requested review from peanutfun and Evelyn-M March 23, 2023 08:49
peanutfun
peanutfun requested changes Mar 23, 2023
View reviewed changes
Copy link
Member

@peanutfun peanutfun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused. What's the improvement of _line_fraction over linspace?

climada/util/lines_polys_handler.py Outdated Show resolved Hide resolved
climada/util/lines_polys_handler.py Show resolved Hide resolved
climada/util/lines_polys_handler.py Outdated Show resolved Hide resolved
@chahank chahank force-pushed the feature/improve_lines_disagg branch from 43dcc40 to 4c606e5 Compare March 23, 2023 13:33
peanutfun
peanutfun reviewed Mar 27, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@chahank
Copy link
Member Author

chahank commented Mar 27, 2023

Thanks @peanutfun !

@chahank chahank merged commit 912127e into develop Mar 27, 2023
@leonie-villiger leonie-villiger deleted the feature/improve_lines_disagg branch April 20, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peanutfun peanutfun peanutfun requested changes

@Evelyn-M Evelyn-M Awaiting requested review from Evelyn-M

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chahank @peanutfun