-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/coverage #637
Merged
Merged
Feature/coverage #637
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f33466f
Coverage test nighlight.py
NicolasColombi f17bde1
Merge branch 'develop' into feature/coverage
NicolasColombi 02def5c
Remove whitespace line 443
NicolasColombi e61e47e
Coverage test for read_bm_file
NicolasColombi ac3656e
Coverage test nightlight
NicolasColombi 77e1977
Merge branch 'develop' into feature/coverage
NicolasColombi b02a92f
Add coverage test for nighlight.py
NicolasColombi baa9f03
Merge branch 'develop' into feature/coverage
NicolasColombi 68d626b
Merge branch 'develop' into feature/coverage
emanuel-schmid ebad46e
Ripristine arguments of ream_bm_files
NicolasColombi 96c4f3c
test.test_nightlight: release gdal file handle
emanuel-schmid e1ef8a6
Merge remote-tracking branch 'origin/develop' into feature/coverage
emanuel-schmid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NicolasColombi : do you know why
band1
was deleted in the previous version? Why is the deletion skipped now?(
del something
summons the garbage collector)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @emanuel-schmid, Yes, it is because in the old version extracting the first band of the image (
band1
) and then reading it as an array was done in 3 steps: 1) get the raster band , convert raster to array, delate the rasterband1
in non array format. By getting the first band and directly reading it as an array (line 446) nothing is stored, so no need to delate anything. Line 446 of the new version does the same as Lines 445 to 447 of the old.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 Thanks!