Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check crs attribute on GDF if no geo is present #566

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Check crs attribute on GDF if no geo is present #566

merged 2 commits into from
Oct 27, 2022

Conversation

tovogt
Copy link
Collaborator

@tovogt tovogt commented Oct 27, 2022 •
edited
Loading

Changes proposed in this PR:

  • Fix the recently failing unittests related to a change in geopandas where an AttributeError would be raised if the crs attribute is used on GeoDataFrames without a geometry column.

PR Author Checklist

PR Reviewer Checklist

@tovogt tovogt requested a review from emanuel-schmid October 27, 2022 10:16
@emanuel-schmid emanuel-schmid merged commit 38b3945 into develop Oct 27, 2022
@emanuel-schmid
Copy link
Collaborator

👏 🚀

@emanuel-schmid emanuel-schmid deleted the feature/fix_geodataframe_crs branch October 27, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emanuel-schmid emanuel-schmid Awaiting requested review from emanuel-schmid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tovogt @emanuel-schmid