Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hazard classmethod for loading xarray Datasets #507
Add Hazard classmethod for loading xarray Datasets #507
Changes from 17 commits
4a9a520
755f11e
525394b
17564d5
cbc1dc5
d90ca87
939968b
b110a94
4283cf6
ab40d1a
2a4283d
dac5dd5
026a33f
528b99e
d96a278
f817bca
fb94fc6
bda69a6
9c68a9e
87033ea
abc9d32
29b74f3
7678d1f
c0fb24b
b8c46a3
7a9ea42
b2eea56
1be9772
ccec87f
c19f9ea
07e8bf7
84b0795
a72112c
d777785
d36bcc2
68c1459
2cffc9a
1ff075d
1eea94c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a quite long method, so maybe a real docstring is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 9c68a9e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand the naming of this method. I also do not understand the docstring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it to
load_data_or_default
, improved the signature and wrote a proper docstring, see 9c68a9eThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.