Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise FileNotFoundError if blob doesn't exist #443

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

crouchcd
Copy link
Contributor

What

_download_blob_bytes should raise FileNotFoundError if the blob to download doesn't exist

Why

An error is raised: 'NoneType' object has no attribute 'download_as_string'. But not the one that was expected: FileNotFoundError: Could not find file <object_name> in <GOOGLE_ACL_DATA_BUCKET>.

How

Remarks

Checklist

Please include and complete the following checklist. You can mark an item as complete with the - [x] prefix:

  • Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • Type Annotations - All new code has been type annotated in the function signatures using type hints
  • Docstrings - Docstrings have been provided for functions
  • Documentation - README and CHANGELOG have been updated to explain major changes & new features
  • Package version - Manually bumped the API package version in requirements.txt if needed

@crouchcd crouchcd requested a review from yongzhi2 April 26, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants