Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder functions frzmlt_bottom_lateral and neutral_coeffs #381

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

TillRasmussen
Copy link
Contributor

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    reorder functions frzmlt_bottom_lateral and neutral_coeffsder to update CDN_ocn before it is used.
    This only changes results when formdrag is applied and fbot_xfer_type) == 'Cdn_ocn'.
  • [ x] Developer(s):
    @TillRasmussen
  • Suggest PR reviewers from list in the column to the right.
    @eclare108213 @apcraig @phil-blain
  • Please copy the PR test results link or provide a summary of testing completed below.
    Not bit for bit when formdrag and Cdn_ocn are set. Otherwize bit for bit
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • [x ] more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • [ x] No
  • Does this PR add any new test cases?
    • Yes
    • [ x] No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • [x ] No, does the documentation need to be updated at a later time?
      • Yes
      • [x ] No
  • Please provide any additional information or relevant details below:
    Replaces Reorder calls to neutral_Coefficients and frzmlt_bottom_lateral - bugfix #380 cleaned up

@apcraig apcraig merged commit 5281c3e into CICE-Consortium:main Dec 9, 2021
@TillRasmussen TillRasmussen deleted the newreorder branch December 10, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants