Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ampersand continuation lines #365

Merged
merged 1 commit into from
May 27, 2021

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented May 27, 2021

PR checklist

  • Short (1 sentence) summary of your PR:
    Clean up redundant ampersand in continuation lines
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    All tests pass, https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#77c4e5fea7d56f5322a45945fd5dcae5490fde9f
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Clean up redundant ampersand in continuation lines. Line with ampersand at the beginning of the line don't conform to the rest of the model coding standard and are being cleaned up now to improve the coverage analysis. See also CICE-Consortium/CICE#604. The lcov line filtering added there prefers not to have ampersand at the beginning of the line.

@apcraig apcraig requested a review from eclare108213 May 27, 2021 17:54
Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bizarre - not sure why all those are there. Thanks for cleaning up.

@apcraig
Copy link
Contributor Author

apcraig commented May 27, 2021

I think it's just legacy code.

@apcraig apcraig merged commit eb59c95 into CICE-Consortium:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants