Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conserv_check implementation #318

Merged
merged 3 commits into from
May 26, 2020
Merged

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented May 25, 2020

PR checklist

  • Short (1 sentence) summary of your PR:
    Update conserv_check implementation

  • Developer(s):
    apcraig

  • Suggest PR reviewers from list in the column to the right.

  • Please copy the PR test results link or provide a summary of testing completed below.
    All tests pass bit-for-bit on cheyenne
    https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#75185037cf80be127deb9a1c26797ab72591e1bb

  • How much do the PR code changes differ from the unmodified code?

    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?

    • Yes
    • No, but this will lead to an update in CICE that depends on these changes
  • Does this PR add any new test cases?

    • Yes
    • No, but adds conserv_check in alt03 test
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)

    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

  • Rename l_conservation_check to conserv_check

  • Add conserv_check to namelist in icepack driver

  • Add conserv_check argument to icepack_parameters so it can be set by a driver

  • Add conserv_check to alt03 test

  • Update column_conservation_check fieldid strings

  • Update documentation including run of icepack.setup --docintfc

apcraig added 2 commits May 25, 2020 13:00
…epack driver namelist and to alt03 test, add conserv_check to icepack_parameters
@apcraig
Copy link
Contributor Author

apcraig commented May 25, 2020

This should be ready to merge. Once merged, I will add this to CICE-Consortium/CICE#450 and update CICE to leverage the new conserv_check icepack parameter argument.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@apcraig apcraig merged commit 487508e into CICE-Consortium:master May 26, 2020
lettie-roach pushed a commit to lettie-roach/Icepack that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants