Incorrect floe size reference #479
Assignees
Labels
Comments
eclare108213
added
the
2024 tutorial
eclare108213
removed
the
2024 tutorial
apcraig
added a commit
to apcraig/Icepack
that referenced
this issue
Oct 2, 2024
- Update Derecho Cray, add -Rp to -O2 standard optimization to address
SAME_TBS compiler bug that is triggered in limited cases. Reported
issue to NCAR. -O2 -Rp changes answers relative to -O2.
- Rename two public Icepack subroutines, but maintain backward compatibility,
use icepack_therm_shared , only: icepack_init_thermo => icepack_init_salinity
use icepack_therm_shared , only: icepack_init_trcr => icepack_init_enthalpy
Update the calls in Icepack driver, but also confirmed it works fine with the old
names as well as in CICE with the old names.
Closes CICE-Consortium#255
- Add a check and abort for negative values in the sqrt in computation of Tin in
function calculate_Tin_from_qin.
Closes CICE-Consortium#482
- Refactor calls to icepack_aggregate to make them consistent. This was part of the
testing for the Derecho Cray bug, and decided to keep the implementation.
- Update comments associated with floeshape constant attribution. Change from
Steele to Rothrock 1984.
Closes CICE-Consortium#479
- Clean up some of the variable declarations in subroutine set_state_var and module
icedrv_state, merge multiple lines to one line and shift to assumed shape arrays
where appropriate.
- Clean up implementation error in icedrv_restart.F90, subroutine restartfile. This subroutine
was using a parameter, ntrcr, directly from icepack_tracers. Switched that to a call to
icepack_query_tracer_sizes.
16 tasks
dabail10
pushed a commit
to ESCOMP/Icepack
that referenced
this issue
Oct 25, 2024
…um#502) * Update Derecho Cray, rename subroutines, minor cleanup Update Derecho Cray, add -Rp to -O2 standard optimization to address SAME_TBS compiler bug that is triggered in limited cases. Reported issue to NCAR. -O2 -Rp changes answers relative to -O2. Rename two public Icepack subroutines, but maintain backward compatibility. Update the calls in Icepack driver, but also confirmed it works fine with the old names as well as in CICE with the old names. Closes CICE-Consortium#255 use icepack_therm_shared , only: icepack_init_thermo => icepack_init_salinity use icepack_therm_shared , only: icepack_init_trcr => icepack_init_enthalpy Add a check and abort for negative values in the sqrt in computation of Tin in function calculate_Tin_from_qin. Closes CICE-Consortium#482 Refactor calls to icepack_aggregate to make them consistent. This was part of the testing for the Derecho Cray bug, and decided to keep the implementation. Update comments associated with floeshape constant attribution. Change from Steele to Rothrock 1984. Closes CICE-Consortium#479 Clean up some of the variable declarations in subroutine set_state_var and module icedrv_state, merge multiple lines to one line and shift to assumed shape arrays where appropriate. Clean up implementation error in icedrv_restart.F90, subroutine restartfile. This subroutine was using a parameter, ntrcr, directly from icepack_tracers. Switched that to a call to icepack_query_tracer_sizes. Update documentation of kice noting it's use with BL99 and MU71. See CICE-Consortium#447. Generate updated interface documentation (./icepack.setup --docintfc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The constant of 0.66 attributed to Steele in Icepack’s comments, is actually from Rothrock,D. A., and A.S. Thomdike, Measuring the seaice floe size distribution, J. Geophys.Res.,89, 6477-6486, 1984. Steele just used it.
Thanks to @proteanplanet for pointing this out.
The text was updated successfully, but these errors were encountered: