Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nuopc/dmi drivers similar to standalone drivers #641

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Update nuopc/dmi drivers similar to standalone drivers #641

merged 1 commit into from
Oct 7, 2021

Conversation

mhrib
Copy link
Contributor

@mhrib mhrib commented Oct 7, 2021 •
edited
Loading

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Update nuopc/dmi drivers and align it as close as possible with standalone drivers. Also introduce optional "stop_now_cpl" alowing CICE to stop correctly in coupled mode after last history-write + restart+dump.
  • Developer(s):
    @mhrib
  • Suggest PR reviewers from list in the column to the right.
    @apcraig @eclare108213
  • Please copy the PR test results link or provide a summary of testing completed below.
    19 measured results of 19 total results
    19 of 19 tests PASSED
    0 of 19 tests PENDING
    0 of 19 tests MISSING data
    0 of 19 tests FAILED
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Also tested on coupled HYCOM-CICE setup at DMI. I think this is the real test:-)

@mhrib mhrib mentioned this pull request Oct 7, 2021
Closed
15 tasks
@apcraig apcraig merged commit db96c72 into CICE-Consortium:main Oct 7, 2021
@mhrib mhrib deleted the CICE2 branch November 8, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apcraig apcraig apcraig approved these changes

@eclare108213 eclare108213 eclare108213 approved these changes

Assignees
No one assigned
Labels
Drivers/coupling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhrib @eclare108213 @apcraig