Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vector directives. #453

Merged
merged 3 commits into from
May 28, 2020
Merged

Remove vector directives. #453

merged 3 commits into from
May 28, 2020

Conversation

dabail10
Copy link
Contributor

@dabail10 dabail10 commented May 28, 2020

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Removes the vector directives for Cray/NEC/Fujitsu. Issue Remove vector directives. #453
  • Developer(s):
    dabail10 (D. Bailey)
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#2ef8862ce630e1b3439fdad3575c0428dc90b38e
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    We are removing these as they don't appear to be used on any current machines.

@dabail10 dabail10 requested review from apcraig and phil-blain May 28, 2020 14:51
Copy link
Member

@phil-blain phil-blain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Dave!

Could I ask you to also remove the -diag-disable 5140 flag in these files:

$ git grep -l ' 5140'
configuration/scripts/machines/Macros.banting_intel
configuration/scripts/machines/Macros.cesium_intel
configuration/scripts/machines/Macros.daley_intel
configuration/scripts/machines/Macros.millikan_intel

Since it won't be needed now that these directives are removed :)

@apcraig apcraig merged commit 2054d09 into CICE-Consortium:master May 28, 2020
@apcraig apcraig mentioned this pull request May 28, 2020
@dabail10 dabail10 deleted the cray branch March 24, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants