Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update travis data download to zenodo, update conda macos Macros file CFLAGS_HOST #424

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Update travis data download to zenodo, update conda macos Macros file CFLAGS_HOST #424

merged 2 commits into from
Mar 30, 2020

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Mar 27, 2020 •
edited
Loading

PR checklist

  • Short (1 sentence) summary of your PR:
    Update travis data download to zenodo
    Update conda macos Macros file CFLAGS_HOST value to deal with older sdk implementations
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Tested on older and newer Macos systems and works as expected, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#105384af7d8243cd470afa7d1503a8706a428753
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Minor update in documentation to point out environment.yml source when needed.

Addresses #422.

@apcraig apcraig changed the title Update conda macos Macros file CFLAGS_HOST value to deal with older sdk implementations Update travis data download to zenodo, update conda macos Macros file CFLAGS_HOST Mar 27, 2020
@apcraig apcraig requested a review from duvivier March 27, 2020 21:29
phil-blain
phil-blain approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@phil-blain phil-blain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Let's hope that getting the input data from Zenodo will be more robust than the UCAR ftp.

@apcraig
Copy link
Contributor Author

apcraig commented Mar 30, 2020

Thanks @phil-blain. I'm also hopeful the input data download will be more reliable. Will keep an eye on that.

@apcraig apcraig merged commit 9ac1863 into CICE-Consortium:master Mar 30, 2020
@apcraig apcraig mentioned this pull request Mar 31, 2020
Closed
@apcraig apcraig deleted the conda_sdk branch August 17, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-blain phil-blain phil-blain approved these changes

@duvivier duvivier duvivier approved these changes

@eclare108213 eclare108213 eclare108213 approved these changes

Assignees
No one assigned
Labels
Porting Priority: Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apcraig @eclare108213 @duvivier @phil-blain