Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cori port and update icepack #416

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Update cori port and update icepack #416

merged 1 commit into from
Mar 10, 2020

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Mar 10, 2020

PR checklist

  • Short (1 sentence) summary of your PR:
    Update cori port due to recent system changes. Update icepack in CICE which also includes the updated cori port.
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Tested on cori, it's bit-for-bit with results from Dec 2019 except an fsd test. In addition, a couple tests failed due to missing input data and I am moving that data now and will retest.
    results
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

@apcraig apcraig requested a review from eclare108213 March 10, 2020 18:29
@apcraig apcraig merged commit 7b43a6f into CICE-Consortium:master Mar 10, 2020
@apcraig apcraig deleted the cori3 branch August 17, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apcraig @eclare108213