Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TravisCI xenial updates #338

Merged
merged 3 commits into from
Jul 30, 2019
Merged

TravisCI xenial updates #338

merged 3 commits into from
Jul 30, 2019

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Jul 29, 2019

PR checklist

  • Short (1 sentence) summary of your PR:
    Update to support xenial build environment in travis CI
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Tested on conrad+gnu. https://github.com/CICE-Consortium/Test-Results/wiki/6a30b42b40.conrad.gnu.190729.190930
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Testing xenial which has become the default build environment on travisCI. It was failing with netcdf. The workaround is to add dist: trusty to the current setup, but this PR attempts to get things working with xenial.

For now, this PR is just providing the ability to test travis. We can decide later how to proceed, whether to stay with trusty or move to xenial, etc.

@apcraig apcraig self-assigned this Jul 29, 2019
@apcraig
Copy link
Contributor Author

apcraig commented Jul 29, 2019

This passes travisCI and I have update testing on conrad+gnu. I think we should merge this to master to allow us to run with the new build environment. Not sure how long the older env will work.

@codecov-io
Copy link

codecov-io commented Jul 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ffee9a7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #338   +/-   ##
=========================================
  Coverage          ?   37.75%           
=========================================
  Files             ?       59           
  Lines             ?    30640           
  Branches          ?        0           
=========================================
  Hits              ?    11567           
  Misses            ?    19073           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffee9a7...6a30b42. Read the comment docs.

@apcraig
Copy link
Contributor Author

apcraig commented Jul 29, 2019

Ignore the codecov reporting. Somehow, that is happening "automatically". I am testing the codecov tools in my sandbox now for CICE. Still need to understand how git and codecov interact.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out so quickly.

@apcraig apcraig merged commit de87b57 into CICE-Consortium:master Jul 30, 2019
@apcraig apcraig deleted the xenial branch August 17, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants